Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent duplicate extraErrors when not live validating #3288

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

heath-freenome
Copy link
Member

Reasons for making this change

Fixed #3169 by merging extraErrors in while preventing duplicates

  • Updated @rjsf/utils to make the mergeObjects() function support a preventDuplicates mode when concatenating arrays
    • Updated the tests to verify this new feature
  • Updated @rjsf/core to use the preventDuplicates mode when merging extraErrors when not live validating
  • Updated validation.md to remove extraneous leading space to fix Localization docs broken #3282
  • Updated utility-functions.md to document the new mode
  • Updated index.md to provide the proper core.cjs.production.min.js package name for unpkg.com fixing Documentation for unpkg is incorrect #3262
  • Updated the CHANGELOG.md accordingly

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome changed the title fix: Prevent duplicated extraErrors when not live validating fix: Prevent duplicate extraErrors when not live validating Dec 8, 2022
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this will fix the bug, but a comment for your consideration, @heath-freenome

packages/utils/src/mergeObjects.ts Show resolved Hide resolved
@heath-freenome heath-freenome merged commit fc6a5ae into rjsf-team:main Dec 9, 2022
@heath-freenome heath-freenome deleted the fix-3169 branch December 9, 2022 17:43
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this pull request Jun 8, 2023
…m#3288)

* fix: Prevent duplicated extraErrors when not live validating
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262
- Updated the `CHANGELOG.md` accordingly

* - Responded to reviewer feedback

* - Fixed url for unpkg directory
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this pull request Jun 8, 2023
…m#3288)

* fix: Prevent duplicated extraErrors when not live validating
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262
- Updated the `CHANGELOG.md` accordingly

* - Responded to reviewer feedback

* - Fixed url for unpkg directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization docs broken ExtraErrors are merged into errorSchema again and again
3 participants